Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WASIX Preparation #3426

Merged
merged 65 commits into from
Jan 16, 2023
Merged

WASIX Preparation #3426

merged 65 commits into from
Jan 16, 2023

Conversation

theduke
Copy link
Contributor

@theduke theduke commented Dec 15, 2022 •
edited
Loading

This commit extracts changes to core libraries made in the WASIX branch.

It is not reasonable to extract the partial commit history, so this is
just a batch commit.

The history will make a bit more sense again if we decide to merge the
WASIX branch with full commit history.

@theduke theduke requested a review from syrusakbary as a code owner December 15, 2022 11:16
@theduke theduke requested review from fschutt and ptitSeb December 15, 2022 11:16
@theduke
Copy link
Contributor Author

theduke commented Dec 15, 2022 •
edited
Loading

@fschutt

The Linux runtime test fails with:

test test_wasmer_create_exe_pirita_works ... compiling to target x86_64-unknown-linux-gnu
packaging /package to .tar.gz: /tmp/.tmpxSTqhk/link.tar.gz
packaging done
tmp tar gz path: /tmp/.tmpxSTqhk/link.tar.gz - exists: true
running: "/home/runner/work/wasmer/wasmer/tests/integration/cli/../../../target/x86_64-unknown-linux-gnu/release/wasmer" "create-exe" "/tmp/.tmp2IYt78/python.wasmer" "--tarball" "/tmp/.tmpxSTqhk/link.tar.gz" "--target" "x86_64-unknown-linux-gnu" "-o" "/tmp/.tmp2IYt78/python"
compilation ok!
Error: python_exe_output_path /tmp/.tmp2IYt78/python does not exist

Is that something unrelated to this PR, or is this something I need to investigate?

syrusakbary
syrusakbary reviewed Dec 15, 2022
View reviewed changes
lib/vm/src/memory.rs Outdated Show resolved Hide resolved
syrusakbary
syrusakbary reviewed Dec 15, 2022
View reviewed changes
lib/vm/src/memory.rs Outdated Show resolved Hide resolved
syrusakbary
syrusakbary reviewed Dec 15, 2022
View reviewed changes
lib/vm/src/memory.rs Outdated Show resolved Hide resolved
syrusakbary
syrusakbary reviewed Dec 15, 2022
View reviewed changes
lib/vm/src/memory.rs Outdated Show resolved Hide resolved
syrusakbary
syrusakbary reviewed Dec 15, 2022
View reviewed changes
lib/vm/src/memory.rs Outdated Show resolved Hide resolved
syrusakbary
syrusakbary reviewed Dec 15, 2022
View reviewed changes
lib/vm/src/memory.rs Outdated Show resolved Hide resolved
syrusakbary
syrusakbary reviewed Dec 15, 2022
View reviewed changes
lib/vm/src/memory.rs Outdated Show resolved Hide resolved
syrusakbary
syrusakbary reviewed Dec 15, 2022
View reviewed changes
lib/vm/src/memory.rs Outdated Show resolved Hide resolved
@theduke theduke force-pushed the wasix-core-changes branch 2 times, most recently from 3725976 to b03f58e Compare December 15, 2022 23:37
theduke
theduke commented Dec 15, 2022
View reviewed changes
lib/api/src/sys/exports.rs Outdated Show resolved Hide resolved
lib/compiler-cranelift/Cargo.toml Outdated Show resolved Hide resolved
lib/types/src/memory.rs Show resolved Hide resolved
lib/api/src/js/export.rs Outdated Show resolved Hide resolved
lib/api/src/js/module.rs Outdated Show resolved Hide resolved
lib/api/src/js/module.rs Show resolved Hide resolved
syrusakbary
syrusakbary reviewed Dec 15, 2022
View reviewed changes
lib/vm/src/mmap.rs Outdated Show resolved Hide resolved
syrusakbary
syrusakbary reviewed Dec 15, 2022
View reviewed changes
lib/vm/src/mmap.rs Outdated Show resolved Hide resolved
syrusakbary
syrusakbary reviewed Dec 15, 2022
View reviewed changes
lib/types/src/store.rs Outdated Show resolved Hide resolved
syrusakbary
syrusakbary approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@theduke theduke enabled auto-merge January 16, 2023 23:25
@theduke theduke merged commit 0785137 into master Jan 16, 2023
@theduke theduke deleted the wasix-core-changes branch January 16, 2023 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-sharratt john-sharratt john-sharratt left review comments

@fschutt fschutt fschutt left review comments

@ptitSeb ptitSeb ptitSeb approved these changes

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@theduke @syrusakbary @ptitSeb @fschutt @john-sharratt